• Roger Quadros's avatar
    mtd: nand: omap: Fix 1-bit Hamming code scheme, omap_calculate_ecc() · 40ddbf50
    Roger Quadros authored
    commit 65b97cf6 introduced in v3.7 caused a regression
    by using a reversed CS_MASK thus causing omap_calculate_ecc to
    always fail. As the NAND base driver never checks for .calculate()'s
    return value, the zeroed ECC values are used as is without showing
    any error to the user. However, this won't work and the NAND device
    won't be guarded by any error code.
    
    Fix the issue by using the correct mask.
    
    Code was tested on omap3beagle using the following procedure
    - flash the primary bootloader (MLO) from the kernel to the first
    NAND partition using nandwrite.
    - boot the board from NAND. This utilizes OMAP ROM loader that
    relies on 1-bit Hamming code ECC.
    
    Fixes: 65b97cf6 (mtd: nand: omap2: handle nand on gpmc)
    
    Cc: <stable@vger.kernel.org>	[3.7+]
    Signed-off-by: default avatarRoger Quadros <rogerq@ti.com>
    Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
    40ddbf50
omap2.c 58.8 KB