• Philipp Rudo's avatar
    s390/kexec_file: fix error handling when applying relocations · 41967a37
    Philipp Rudo authored
    arch_kexec_apply_relocations_add currently ignores all errors returned
    by arch_kexec_do_relocs. This means that every unknown relocation is
    silently skipped causing unpredictable behavior while the relocated code
    runs. Fix this by checking for errors and fail kexec_file_load if an
    unknown relocation type is encountered.
    
    The problem was found after gcc changed its behavior and used
    R_390_PLT32DBL relocations for brasl instruction and relied on ld to
    resolve the relocations in the final link in case direct calls are
    possible. As the purgatory code is only linked partially (option -r)
    ld didn't resolve the relocations leaving them for arch_kexec_do_relocs.
    But arch_kexec_do_relocs doesn't know how to handle R_390_PLT32DBL
    relocations so they were silently skipped. This ultimately caused an
    endless loop in the purgatory as the brasl instructions kept branching
    to itself.
    
    Fixes: 71406883 ("s390/kexec_file: Add kexec_file_load system call")
    Reported-by: default avatarTao Liu <ltao@redhat.com>
    Signed-off-by: default avatarPhilipp Rudo <prudo@redhat.com>
    Link: https://lore.kernel.org/r/20211208130741.5821-3-prudo@redhat.comSigned-off-by: default avatarHeiko Carstens <hca@linux.ibm.com>
    41967a37
machine_kexec_file.c 8.48 KB