• Jay Vosburgh's avatar
    [PATCH] bonding: UPDATED hash-table corruption in bond_alb.c · 5af47b2f
    Jay Vosburgh authored
    	I believe I see the race Michael refers to (tlb_choose_channel
    may set head, which tlb_init_slave clears), although I was not able to
    reproduce it.  I have updated his patch for the current netdev-2.6.git
    tree and added a version update.  His original comment follows:
    
    Our systems have been crashing during testing of PCI HotPlug
    support in the various networking components.  We've faulted in
    the bonding driver due to a bug in bond_alb.c:tlb_clear_slave()
    
    In that routine, the last modification to the TLB hash table is
    made without protection of the lock, allowing a race that can lead
    tlb_choose_channel() to select an invalid table element.
    
    	-J
    Signed-off-by: default avatarJeff Garzik <jgarzik@pobox.com>
    5af47b2f
bond_alb.c 42.4 KB