• Hans de Goede's avatar
    ACPI: video: Make acpi_video_backlight_use_native() always return true · 454d61a5
    Hans de Goede authored
    Testing has shown that there are quite a few laptop models which rely
    on native backlight control and which do not support ACPI video bus
    backlight control, causing __acpi_video_get_backlight_type() to return
    vendor. Known Windows laptop models affected by this are:
    
    Acer Aspire 1640
    HP Compaq nc6120
    IBM ThinkPad X40
    System76 Starling Star1
    
    and the following MacBook models are affected too:
    
    Apple MacBook 2.1
    Apple MacBook 4.1
    Apple MacBook Pro 7.1
    
    the list of affected Windows laptop models is likely just the top of
    the iceberg. So for now lets undo the change to not register native
    backlight class devices when __acpi_video_get_backlight_type() != native.
    
    Since as part of the backlight-detect refactor the detection code now
    relies on the GPU drivers calling acpi_video_backlight_use_native() to
    learn that native backlight support is available we cannot just remove
    the acpi_video_backlight_use_native() calls from the GPU drivers.
    
    Instead modify acpi_video_backlight_use_native() to always return true
    for now. This is meant as a temporary work-around, which will be removed
    again when the heuristics from __acpi_video_get_backlight_type() have
    been improved so that they will return native on affected models.
    Reported-by: default avatarMatthew Garrett <mjg59@srcf.ucam.org>
    Reported-by: default avatarJohn Warriner <taijitu@cox.net>
    Reported-by: default avatarScott Ostrander <sos12_3@hotmail.com>
    Reported-by: default avatarMatthias Rampke <matthias.rampke@googlemail.com>
    Reported-by: default avatarMilan Hodoscek <hmilan@gmail.com>
    Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
    454d61a5
video_detect.c 20.4 KB