• Jeremy Sowden's avatar
    staging: ccree: fixed pointer signedness warnings. · d63923ff
    Jeremy Sowden authored
    The driver uses a mixture of signed and unsigned integer variables for
    holding arrays lengths and indices, which gives rise to the following
    sparse warnings when the addresses of signed variables are passed to
    functions expecting pointers to unsigned integers:
    
      drivers/staging/ccree/cc_buffer_mgr.c:1050:46: warning: incorrect type in argument 4 (different signedness)
      drivers/staging/ccree/cc_buffer_mgr.c:1050:46:    expected unsigned int [usertype] *lbytes
      drivers/staging/ccree/cc_buffer_mgr.c:1050:46:    got int *<noident>
      drivers/staging/ccree/cc_buffer_mgr.c:1083:62: warning: incorrect type in argument 7 (different signedness)
      drivers/staging/ccree/cc_buffer_mgr.c:1083:62:    expected unsigned int [usertype] *lbytes
      drivers/staging/ccree/cc_buffer_mgr.c:1083:62:    got int *<noident>
      drivers/staging/ccree/cc_buffer_mgr.c:1092:46: warning: incorrect type in argument 4 (different signedness)
      drivers/staging/ccree/cc_buffer_mgr.c:1092:46:    expected unsigned int [usertype] *lbytes
      drivers/staging/ccree/cc_buffer_mgr.c:1092:46:    got int *<noident>
      drivers/staging/ccree/cc_buffer_mgr.c:1120:49: warning: incorrect type in argument 4 (different signedness)
      drivers/staging/ccree/cc_buffer_mgr.c:1120:49:    expected unsigned int [usertype] *src_last_bytes
      drivers/staging/ccree/cc_buffer_mgr.c:1120:49:    got int *<noident>
      drivers/staging/ccree/cc_buffer_mgr.c:1121:49: warning: incorrect type in argument 5 (different signedness)
      drivers/staging/ccree/cc_buffer_mgr.c:1121:49:    expected unsigned int [usertype] *dst_last_bytes
      drivers/staging/ccree/cc_buffer_mgr.c:1121:49:    got int *<noident>
      drivers/staging/ccree/cc_buffer_mgr.c:1124:49: warning: incorrect type in argument 2 (different signedness)
      drivers/staging/ccree/cc_buffer_mgr.c:1124:49:    expected unsigned int [usertype] *src_last_bytes
      drivers/staging/ccree/cc_buffer_mgr.c:1124:49:    got int *<noident>
      drivers/staging/ccree/cc_buffer_mgr.c:1125:44: warning: incorrect type in argument 3 (different signedness)
      drivers/staging/ccree/cc_buffer_mgr.c:1125:44:    expected unsigned int [usertype] *dst_last_bytes
      drivers/staging/ccree/cc_buffer_mgr.c:1125:44:    got int *<noident>
      drivers/staging/ccree/cc_cipher.c:697:67: warning: incorrect type in argument 6 (different signedness)
      drivers/staging/ccree/cc_cipher.c:697:67:    expected unsigned int *seq_size
      drivers/staging/ccree/cc_cipher.c:697:67:    got int *<noident>
      drivers/staging/ccree/cc_cipher.c:700:31: warning: incorrect type in argument 8 (different signedness)
      drivers/staging/ccree/cc_cipher.c:700:31:    expected unsigned int *seq_size
      drivers/staging/ccree/cc_cipher.c:700:31:    got int *<noident>
      drivers/staging/ccree/cc_hash.c:480:57: warning: incorrect type in argument 6 (different signedness)
      drivers/staging/ccree/cc_hash.c:480:57:    expected unsigned int *seq_size
      drivers/staging/ccree/cc_hash.c:480:57:    got int *<noident>
      drivers/staging/ccree/cc_hash.c:530:57: warning: incorrect type in argument 6 (different signedness)
      drivers/staging/ccree/cc_hash.c:530:57:    expected unsigned int *seq_size
      drivers/staging/ccree/cc_hash.c:530:57:    got int *<noident>
      drivers/staging/ccree/cc_hash.c:1305:43: warning: incorrect type in argument 3 (different signedness)
      drivers/staging/ccree/cc_hash.c:1305:43:    expected unsigned int *seq_size
      drivers/staging/ccree/cc_hash.c:1305:43:    got int *<noident>
      drivers/staging/ccree/cc_hash.c:1307:43: warning: incorrect type in argument 3 (different signedness)
      drivers/staging/ccree/cc_hash.c:1307:43:    expected unsigned int *seq_size
      drivers/staging/ccree/cc_hash.c:1307:43:    got int *<noident>
      drivers/staging/ccree/cc_hash.c:1317:69: warning: incorrect type in argument 6 (different signedness)
      drivers/staging/ccree/cc_hash.c:1317:69:    expected unsigned int *seq_size
      drivers/staging/ccree/cc_hash.c:1317:69:    got int *<noident>
      drivers/staging/ccree/cc_hash.c:1390:43: warning: incorrect type in argument 3 (different signedness)
      drivers/staging/ccree/cc_hash.c:1390:43:    expected unsigned int *seq_size
      drivers/staging/ccree/cc_hash.c:1390:43:    got int *<noident>
      drivers/staging/ccree/cc_hash.c:1393:43: warning: incorrect type in argument 3 (different signedness)
      drivers/staging/ccree/cc_hash.c:1393:43:    expected unsigned int *seq_size
      drivers/staging/ccree/cc_hash.c:1393:43:    got int *<noident>
      drivers/staging/ccree/cc_hash.c:1404:69: warning: incorrect type in argument 6 (different signedness)
      drivers/staging/ccree/cc_hash.c:1404:69:    expected unsigned int *seq_size
      drivers/staging/ccree/cc_hash.c:1404:69:    got int *<noident>
      drivers/staging/ccree/cc_hash.c:1469:43: warning: incorrect type in argument 3 (different signedness)
      drivers/staging/ccree/cc_hash.c:1469:43:    expected unsigned int *seq_size
      drivers/staging/ccree/cc_hash.c:1469:43:    got int *<noident>
      drivers/staging/ccree/cc_hash.c:1472:43: warning: incorrect type in argument 3 (different signedness)
      drivers/staging/ccree/cc_hash.c:1472:43:    expected unsigned int *seq_size
      drivers/staging/ccree/cc_hash.c:1472:43:    got int *<noident>
      drivers/staging/ccree/cc_hash.c:1483:69: warning: incorrect type in argument 6 (different signedness)
      drivers/staging/ccree/cc_hash.c:1483:69:    expected unsigned int *seq_size
      drivers/staging/ccree/cc_hash.c:1483:69:    got int *<noident>
      drivers/staging/ccree/cc_aead.c:2011:37: warning: incorrect type in argument 3 (different signedness)
      drivers/staging/ccree/cc_aead.c:2011:37:    expected unsigned int *seq_size
      drivers/staging/ccree/cc_aead.c:2011:37:    got int *<noident>
      drivers/staging/ccree/cc_aead.c:2017:45: warning: incorrect type in argument 3 (different signedness)
      drivers/staging/ccree/cc_aead.c:2017:45:    expected unsigned int *seq_size
      drivers/staging/ccree/cc_aead.c:2017:45:    got int *<noident>
      drivers/staging/ccree/cc_aead.c:2020:45: warning: incorrect type in argument 3 (different signedness)
      drivers/staging/ccree/cc_aead.c:2020:45:    expected unsigned int *seq_size
      drivers/staging/ccree/cc_aead.c:2020:45:    got int *<noident>
      drivers/staging/ccree/cc_aead.c:2024:44: warning: incorrect type in argument 3 (different signedness)
      drivers/staging/ccree/cc_aead.c:2024:44:    expected unsigned int *seq_size
      drivers/staging/ccree/cc_aead.c:2024:44:    got int *<noident>
      drivers/staging/ccree/cc_aead.c:2026:44: warning: incorrect type in argument 3 (different signedness)
      drivers/staging/ccree/cc_aead.c:2026:44:    expected unsigned int *seq_size
      drivers/staging/ccree/cc_aead.c:2026:44:    got int *<noident>
    
    This patch fixes those warnings by converting those signed variables to
    unsigned as follows:
    
      * changed the types of a number of index and length variables from
        signed to unsigned integer types.
    
      * changed the return-types of a couple of functions that return length
        values which are assigned to one of these variables from signed to
        unsigned integer types.
    Signed-off-by: default avatarJeremy Sowden <jeremy@azazel.net>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    d63923ff
cc_hash.c 65.8 KB