• Lars-Peter Clausen's avatar
    regmap: rbtree: Reduce number of nodes, take 2 · 472fdec7
    Lars-Peter Clausen authored
    Support for reducing the number of nodes and memory consumption of the rbtree
    cache by allowing for small unused holes in the node's register cache block was
    initially added in commit 0c7ed856 ("regmap: Cut down on the average # of nodes
    in the rbtree cache"). But the commit had problems and so its effect was
    reverted again in commit 4e67fb5f ("regmap: rbtree: Fix overlapping rbnodes.").
    This patch brings the feature back of reducing the average number of nodes,
    which will speedup node look-up, while at the same time also reducing the memory
    usage of the rbtree cache. This patch takes a slightly different approach than
    the original patch though. It modifies the adjacent node look-up to not only
    consider nodes that are just one to the left or the right of the register but
    any node that falls in a certain range around the register. The range is
    calculated based on how much memory it would take to allocate a new node
    compared to how much memory it takes adding a set of unused registers to an
    existing node. E.g. if a node takes up 24 bytes and each register in a block
    uses 1 byte the range will be from the register address - 24 to the register
    address + 24. If we find a node that falls within this range it is cheaper or as
    expensive to add the register to the existing node and have a couple of unused
    registers in the node's cache compared to allocating a new node.
    Signed-off-by: default avatarLars-Peter Clausen <lars@metafoo.de>
    Signed-off-by: default avatarMark Brown <broonie@linaro.org>
    472fdec7
regcache-rbtree.c 11.8 KB