• Ralf Baechle's avatar
    [media] MEDIA: Fix non-ISA_DMA_API link failure of sound code · 4756fc64
    Ralf Baechle authored
    sound/isa/es18xx.c: In function ‘snd_es18xx_playback1_prepare’:
    sound/isa/es18xx.c:501:9: error: implicit declaration of function ‘snd_dma_program’ [-Werror=implicit-function-declaration]
    sound/isa/es18xx.c: In function ‘snd_es18xx_playback_pointer’:
    sound/isa/es18xx.c:818:3: error: implicit declaration of function ‘snd_dma_pointer’ [-Werror=implicit-function-declaration]
    cc1: some warnings being treated as errors
    make[2]: *** [sound/isa/es18xx.o] Error 1
    sound/isa/sscape.c: In function ‘upload_dma_data’:
    sound/isa/sscape.c:481:3: error: implicit declaration of function ‘snd_dma_program’ [-Werror=implicit-function-declaration]
    cc1: some warnings being treated as errors
    make[2]: *** [sound/isa/sscape.o] Error 1
    sound/isa/ad1816a/ad1816a_lib.c: In function ‘snd_ad1816a_playback_prepare’:
    sound/isa/ad1816a/ad1816a_lib.c:244:2: error: implicit declaration of function ‘snd_dma_program’ [-Werror=implicit-function-declaration]
    sound/isa/ad1816a/ad1816a_lib.c: In function ‘snd_ad1816a_playback_pointer’:
    sound/isa/ad1816a/ad1816a_lib.c:302:2: error: implicit declaration of function ‘snd_dma_pointer’ [-Werror=implicit-function-declaration]
    sound/isa/ad1816a/ad1816a_lib.c: In function ‘snd_ad1816a_free’:
    sound/isa/ad1816a/ad1816a_lib.c:544:3: error: implicit declaration of function ‘snd_dma_disable’ [-Werror=implicit-function-declaration]
    cc1: some warnings being treated as errors
    make[3]: *** [sound/isa/ad1816a/ad1816a_lib.o] Error 1
    make[3]: Target `__build' not remade because of errors.
    make[2]: *** [sound/isa/ad1816a] Error 2
    sound/isa/es1688/es1688_lib.c: In function ‘snd_es1688_playback_prepare’:
    sound/isa/es1688/es1688_lib.c:417:2: error: implicit declaration of function ‘snd_dma_program’ [-Werror=implicit-function-declaration]
    sound/isa/es1688/es1688_lib.c: In function ‘snd_es1688_playback_pointer’:
    sound/isa/es1688/es1688_lib.c:509:2: error: implicit declaration of function ‘snd_dma_pointer’ [-Werror=implicit-function-declaration]
    cc1: some warnings being treated as errors
    make[3]: *** [sound/isa/es1688/es1688_lib.o] Error 1
    make[3]: Target `__build' not remade because of errors.
    make[2]: *** [sound/isa/es1688] Error 2
    sound/isa/gus/gus_dma.c: In function ‘snd_gf1_dma_program’:
    sound/isa/gus/gus_dma.c:79:2: error: implicit declaration of function ‘snd_dma_program’ [-Werror=implicit-function-declaration]
    sound/isa/gus/gus_dma.c: In function ‘snd_gf1_dma_done’:
    sound/isa/gus/gus_dma.c:177:3: error: implicit declaration of function ‘snd_dma_disable’ [-Werror=implicit-function-declaration]
    cc1: some warnings being treated as errors
    make[3]: *** [sound/isa/gus/gus_dma.o] Error 1
    sound/isa/gus/gus_pcm.c: In function ‘snd_gf1_pcm_capture_prepare’:
    sound/isa/gus/gus_pcm.c:591:2: error: implicit declaration of function ‘snd_dma_program’ [-Werror=implicit-function-declaration]
    sound/isa/gus/gus_pcm.c: In function ‘snd_gf1_pcm_capture_pointer’:
    sound/isa/gus/gus_pcm.c:619:2: error: implicit declaration of function ‘snd_dma_pointer’ [-Werror=implicit-function-declaration]
    cc1: some warnings being treated as errors
    make[3]: *** [sound/isa/gus/gus_pcm.o] Error 1
    make[3]: Target `__build' not remade because of errors.
    make[2]: *** [sound/isa/gus] Error 2
    sound/isa/sb/sb16_csp.c: In function ‘snd_sb_csp_ioctl’:
    sound/isa/sb/sb16_csp.c:228:227: error: case label does not reduce to an integer constant
    make[3]: *** [sound/isa/sb/sb16_csp.o] Error 1
    sound/isa/sb/sb16_main.c: In function ‘snd_sb16_playback_prepare’:
    sound/isa/sb/sb16_main.c:276:2: error: implicit declaration of function ‘snd_dma_program’ [-Werror=implicit-function-declaration]
    sound/isa/sb/sb16_main.c: In function ‘snd_sb16_playback_pointer’:
    sound/isa/sb/sb16_main.c:456:2: error: implicit declaration of function ‘snd_dma_pointer’ [-Werror=implicit-function-declaration]
    cc1: some warnings being treated as errors
    make[3]: *** [sound/isa/sb/sb16_main.o] Error 1
    sound/isa/sb/sb8_main.c: In function ‘snd_sb8_playback_prepare’:
    sound/isa/sb/sb8_main.c:172:3: error: implicit declaration of function ‘snd_dma_program’ [-Werror=implicit-function-declaration]
    sound/isa/sb/sb8_main.c: In function ‘snd_sb8_playback_pointer’:
    sound/isa/sb/sb8_main.c:425:2: error: implicit declaration of function ‘snd_dma_pointer’ [-Werror=implicit-function-declaration]
    cc1: some warnings being treated as errors
    make[3]: *** [sound/isa/sb/sb8_main.o] Error 1
    make[3]: Target `__build' not remade because of errors.
    make[2]: *** [sound/isa/sb] Error 2
    sound/isa/wss/wss_lib.c: In function ‘snd_wss_playback_prepare’:
    sound/isa/wss/wss_lib.c:1025:2: error: implicit declaration of function ‘snd_dma_program’ [-Werror=implicit-function-declaration]
    sound/isa/wss/wss_lib.c: In function ‘snd_wss_playback_pointer’:
    sound/isa/wss/wss_lib.c:1160:2: error: implicit declaration of function ‘snd_dma_pointer’ [-Werror=implicit-function-declaration]
    sound/isa/wss/wss_lib.c: In function ‘snd_wss_free’:
    sound/isa/wss/wss_lib.c:1695:3: error: implicit declaration of function ‘snd_dma_disable’ [-Werror=implicit-function-declaration]
    cc1: some warnings being treated as errors
    make[3]: *** [sound/isa/wss/wss_lib.o] Error 1
    warning: (RADIO_MIROPCM20) selects SND_ISA which has unmet direct dependencies (SOUND && !M68K && SND && ISA && ISA_DMA_API)
    
    A build with ISA && ISA_DMA && !ISA_DMA_API results in:
      CC      sound/isa/es18xx.o
      CC      sound/isa/sscape.o
      CC      sound/isa/ad1816a/ad1816a_lib.o
      CC      sound/isa/es1688/es1688_lib.o
      CC      sound/isa/gus/gus_dma.o
      CC      sound/isa/gus/gus_pcm.o
      CC      sound/isa/sb/sb16_csp.o
      CC      sound/isa/sb/sb16_main.o
      CC      sound/isa/sb/sb8_main.o
      CC      sound/isa/wss/wss_lib.o
    
    The root cause for this is hidden in this Kconfig warning:
    
    Adding a dependency on ISA_DMA_API to RADIO_MIROPCM20 fixes these issues.
    Signed-off-by: default avatarRalf Baechle <ralf@linux-mips.org>
    Acked-by: default avatarTakashi Iwai <tiwai@suse.de>
    Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
    4756fc64
Kconfig 15.2 KB