• Thomas Weißschuh's avatar
    cpufreq: amd-pstate: fix global sysfs attribute type · 5e720f8c
    Thomas Weißschuh authored
    In commit 3666062b ("cpufreq: amd-pstate: move to use bus_get_dev_root()")
    the "amd_pstate" attributes where moved from a dedicated kobject to the
    cpu root kobject.
    
    While the dedicated kobject expects to contain kobj_attributes the root
    kobject needs device_attributes.
    
    As the changed arguments are not used by the callbacks it works most of
    the time.
    However CFI will detect this issue:
    
    [ 4947.849350] CFI failure at dev_attr_show+0x24/0x60 (target: show_status+0x0/0x70; expected type: 0x8651b1de)
    ...
    [ 4947.849409] Call Trace:
    [ 4947.849410]  <TASK>
    [ 4947.849411]  ? __warn+0xcf/0x1c0
    [ 4947.849414]  ? dev_attr_show+0x24/0x60
    [ 4947.849415]  ? report_cfi_failure+0x4e/0x60
    [ 4947.849417]  ? handle_cfi_failure+0x14c/0x1d0
    [ 4947.849419]  ? __cfi_show_status+0x10/0x10
    [ 4947.849420]  ? handle_bug+0x4f/0x90
    [ 4947.849421]  ? exc_invalid_op+0x1a/0x60
    [ 4947.849422]  ? asm_exc_invalid_op+0x1a/0x20
    [ 4947.849424]  ? __cfi_show_status+0x10/0x10
    [ 4947.8494...
    5e720f8c
amd-pstate.c 38.1 KB