• Chris Wilson's avatar
    drm/i915: Disable the mmio.debug WARN after it fires · 48572edd
    Chris Wilson authored
    If we have a single unclaimed register, we will have lots. A WARN for
    each one makes the machine unusable and does not aid debugging. Convert
    the i915.mmio_debug option to a counter for how many WARNs to fire
    before shutting up. Even when i915.mmio_debug was disabled it would
    continue to shout an *ERROR* for every interrupt, without any
    information at all for debugging.
    
    The massive verbiage was added in
    commit 5978118c
    Author: Paulo Zanoni <paulo.r.zanoni@intel.com>
    Date:   Wed Jul 16 17:49:29 2014 -0300
    
        drm/i915: reorganize the unclaimed register detection code
    
    v2: Automatically enable invalid mmio reporting for the *next* invalid
    access if mmio_debug is disabled by default. This should give us clearer
    debug information without polluting the logs too much.
    v3: Compile fixes, rebase.
    Signed-off-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
    Cc: Rodrigo Vivi <rodrigo.vivi@gmail.com>
    Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
    Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
    Reviewed-by: default avatarPaulo Zanoni <paulo.r.zanoni@intel.com>
    [danvet: Update modparam text per the thread.]
    Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
    48572edd
intel_uncore.c 38.5 KB