• Paul Mundt's avatar
    sh: DSP save/restore ordering and a0 sign extension fixups. · 485f0720
    Paul Mundt authored
    As an excellent indicator of how much testing the DSP code gets, a couple
    of rather glaring bugs in the DSP save/restore paths were found:
    
    - In the DSP restore case a0 needs to be popped off before a0g,
      or the value of a0g is clobbered by the MSB of a0 in the case
      of sign extension.
    
    - Beyond that, the save and restore orders were out of sync,
      so this fixes that up as well. At the same time, we switch over
      to using movs.l for both the save and restore of the general DSP
      registers as opposed to using sts.l (which was initially put in
      place to work around a bug in ancient binutils versions which
      the kernel no longer supports).
    Reported-by: default avatarChee Soon Yip <yip.cheesoon@renesas.com>
    Cc: Chu Lih Kwek <kwek.chulih@renesas.com>,
    Cc: General Lai <general.lai@renesas.com>,
    Cc: Robert Cozens <Robert.Cozens@renesas.com>
    Signed-off-by: default avatarPaul Mundt <lethal@linux-sh.org>
    485f0720
system_32.h 5.51 KB