• Christoph Lameter's avatar
    Remove set_migrateflags() · 488514d1
    Christoph Lameter authored
    Migrate flags must be set on slab creation as agreed upon when the antifrag
    logic was reviewed.  Otherwise some slabs of a slabcache will end up in the
    unmovable and others in the reclaimable section depending on which flag was
    active when a new slab page was allocated.
    
    This likely slid in somehow when antifrag was merged. Remove it.
    
    The buffer_heads are always allocated with __GFP_RECLAIMABLE because the
    SLAB_RECLAIM_ACCOUNT option is set.  The set_migrateflags() never had any
    effect there.
    
    Radix tree allocations are not directly reclaimable but they are allocated
    with __GFP_RECLAIMABLE set on each allocation.  We now set
    SLAB_RECLAIM_ACCOUNT on radix tree slab creation making sure that radix
    tree slabs are consistently placed in the reclaimable section.  Radix tree
    slabs will also be accounted as such.
    
    There is then no user left of set_migratepages. So remove it.
    Signed-off-by: default avatarChristoph Lameter <clameter@sgi.com>
    Cc: Mel Gorman <mel@csn.ul.ie>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    488514d1
radix-tree.c 27.3 KB