• Thomas Gleixner's avatar
    net: hip04: Make tx coalesce timer actually work · 48b63776
    Thomas Gleixner authored
    The code sets the expiry value of the timer to a relative value and
    starts it with hrtimer_start_expires. That's fine, but that only works
    once. The timer is started in relative mode, so the expiry value gets
    overwritten with the absolut expiry time (now + expiry).
    
    So once the timer expired, a new call to hrtimer_start_expires results
    in an immidiately expired timer, because the expiry value is
    already in the past.
    
    Use the proper mechanisms to (re)start the timer in the intended way.
    Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
    Cc: "David S. Miller" <davem@davemloft.net>
    Cc: dingtianhong <dingtianhong@huawei.com>
    Cc: Arnd Bergmann <arnd@arndb.de>
    Cc: Zhangfei Gao <zhangfei.gao@linaro.org>
    Cc: Dan Carpenter <dan.carpenter@oracle.com>
    Cc: netdev@vger.kernel.org
    Acked-by: default avatarDing Tianhong <dingtianhong@huawei.com>
    Acked-by: default avatarArnd Bergmann <arnd@arndb.de>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    48b63776
hip04_eth.c 24.7 KB