• David Hildenbrand's avatar
    KVM: s390: cmma: don't check entry content · 4a5e7e38
    David Hildenbrand authored
    We should never inject an exception after we manually rewound the PSW
    (to retry the ESSA instruction in this case). This will mess up the PSW.
    So this never worked and therefore never really triggered.
    
    Looking at the details, we don't even have to perform any validity checks.
    1. Bits 52-63 of an entry are stored as 0 by the hardware.
    2. We are dealing with absolute addresses but only check for the prefix
       starting at address 0. This isn't correct and doesn't make much sense,
       cpus could still zap the prefix of other cpus. But as prefix pages
       cannot be swapped out without a notifier being called for the affected
       VCPU, a zap can never remove a protected prefix.
    Reviewed-by: default avatarDominik Dingel <dingel@linux.vnet.ibm.com>
    Signed-off-by: default avatarDavid Hildenbrand <dahi@linux.vnet.ibm.com>
    Signed-off-by: default avatarChristian Borntraeger <borntraeger@de.ibm.com>
    4a5e7e38
priv.c 27.7 KB