• Andrzej Hajda's avatar
    efi: Fix handling error value in fdt_find_uefi_params · 4af9ed57
    Andrzej Hajda authored
    of_get_flat_dt_subnode_by_name can return negative value in case of error.
    Assigning the result to unsigned variable and checking if the variable
    is lesser than zero is incorrect and always false.
    The patch fixes it by using signed variable to check the result.
    
    The problem has been detected using semantic patch
    scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci
    Signed-off-by: default avatarAndrzej Hajda <a.hajda@samsung.com>
    Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
    Cc: Marek Szyprowski <m.szyprowski@samsung.com>
    Cc: Ingo Molnar <mingo@kernel.org>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: "H. Peter Anvin" <hpa@zytor.com>
    Cc: Shawn Lin <shawn.lin@rock-chips.com>
    Cc: Mark Rutland <mark.rutland@arm.com>
    Cc: <stable@vger.kernel.org>
    Signed-off-by: default avatarMatt Fleming <matt@codeblueprint.co.uk>
    4af9ed57
efi.c 20 KB