• Lorenzo Stoakes's avatar
    mm: abstract merge for new VMAs into vma_merge_new_vma() · 4b5f2d20
    Lorenzo Stoakes authored
    Only in mmap_region() and copy_vma() do we attempt to merge VMAs which
    occupy entirely new regions of virtual memory.
    
    We can abstract this logic and make the intent of this invocations of it
    completely explicit, rather than invoking vma_merge() with an inscrutable
     wall of parameters.
    
    This also paves the way for a simplification of the core vma_merge()
    implementation, as we seek to make it entirely an implementation detail.
    
    The VMA merge call in mmap_region() occurs only for file-backed mappings,
    where each of the parameters previously specified as NULL are defaulted to
    NULL in vma_init() (called by vm_area_alloc()).
    
    This matches the previous behaviour of specifying NULL for a number of
    fields, however note that prior to this call we pass the VMA to the file
    system driver via call_mmap(), which may in theory adjust fields that we
    pass in to vma_merge_new_vma().
    
    Therefore we actually resolve an oversight here by allowing for the fact
    that the driver may have done this.
    
    Link: https://lkml.kernel.org/r/3dc71d17e307756a54781d4a4ce7315cf8b18bea.1697043508.git.lstoakes@gmail.comSigned-off-by: default avatarLorenzo Stoakes <lstoakes@gmail.com>
    Reviewed-by: default avatarVlastimil Babka <vbabka@suse.cz>
    Cc: Alexander Viro <viro@zeniv.linux.org.uk>
    Cc: Christian Brauner <brauner@kernel.org>
    Cc: Liam R. Howlett <Liam.Howlett@oracle.com>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    4b5f2d20
mmap.c 106 KB