• Steven Rostedt (Google)'s avatar
    tracing/user_events: Use print_format_fields() for trace output · 4bec284c
    Steven Rostedt (Google) authored
    Currently, user events are shown using the "hex" output for "safety"
    reasons as one cannot trust user events behaving nicely. But the hex
    output is not the only utility for safe outputting of trace events. The
    print_event_fields() is just as safe and gives user readable output.
    
    Before:
             example-839     [001] .....    43.222244:
    00000000: b1 06 00 00 47 03 00 00 00 00 00 00              ....G.......
             example-839     [001] .....    43.564433:
    00000000: b1 06 00 00 47 03 00 00 01 00 00 00              ....G.......
             example-839     [001] .....    43.763917:
    00000000: b1 06 00 00 47 03 00 00 02 00 00 00              ....G.......
             example-839     [001] .....    43.967929:
    00000000: b1 06 00 00 47 03 00 00 03 00 00 00              ....G.......
    
    After:
    
             example-837     [006] .....    55.739249: test: count=0x0 (0)
             example-837     [006] .....   111.104784: test: count=0x1 (1)
             example-837     [006] .....   111.268444: test: count=0x2 (2)
             example-837     [006] .....   111.416533: test: count=0x3 (3)
             example-837     [006] .....   111.542859: test: count=0x4 (4)
    
    Link: https://lore.kernel.org/linux-trace-kernel/20230328151413.4770b8d7@gandalf.local.home
    
    Cc: Masami Hiramatsu <mhiramat@kernel.org>
    Cc: Mark Rutland <mark.rutland@arm.com>
    Cc: Beau Belgrave <beaub@linux.microsoft.com>
    Signed-off-by: default avatarSteven Rostedt (Google) <rostedt@goodmis.org>
    4bec284c
trace_events_user.c 54.9 KB