• Amit Shah's avatar
    hwrng: virtio - ensure reads happen after successful probe · e052dbf5
    Amit Shah authored
    The hwrng core asks for random data in the hwrng_register() call itself
    from commit d9e79726.  This doesn't play well with virtio -- the
    DRIVER_OK bit is only set by virtio core on a successful probe, and
    we're not yet out of our probe routine when this call is made.  This
    causes the host to not acknowledge any requests we put in the virtqueue,
    and the insmod or kernel boot process just waits for data to arrive from
    the host, which never happens.
    
    CC: Kees Cook <keescook@chromium.org>
    CC: Jason Cooper <jason@lakedaemon.net>
    CC: Herbert Xu <herbert@gondor.apana.org.au>
    CC: <stable@vger.kernel.org> # For v3.15+
    Reviewed-by: default avatarJason Cooper <jason@lakedaemon.net>
    Signed-off-by: default avatarAmit Shah <amit.shah@redhat.com>
    Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
    e052dbf5
virtio-rng.c 4.68 KB