• Jacob Keller's avatar
    fm10k: fix documentation of fm10k_tlv_parse_attr · 4e160f2a
    Jacob Keller authored
    fm10k_tlv_parse_attr is supposed to return FM10K_NOT_IMPLEMENTED for any
    TLV who's attribute id lies outside the range of results. It does not do
    this today. In addition, the documentation does not indicate that other
    attributes which are not implemented for a given TLV will be silently
    ignored. Fix this. Clean up the logic so that we don't rely on the fact
    that FM10K_NOT_IMPLEMENTED is greater than zero, as this can easily
    cause confusion.
    
    A future extension could look into some way of reporting unknown TLVs
    in order to make issues more easily discoverable. We can't just return
    FM10K_NOT_IMPLEMENTED here because we don't want to drop the entire
    message if it has an unknown TLV.
    
    While here, update the copyright year.
    Signed-off-by: default avatarJacob Keller <jacob.e.keller@intel.com>
    Tested-by: default avatarKrishneil Singh <Krishneil.k.singh@intel.com>
    Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
    4e160f2a
fm10k_tlv.c 24.4 KB