• Namhyung Kim's avatar
    perf record: Move probing cgroup sampling support · 4f2abe91
    Namhyung Kim authored
    I found that checking cgroup sampling support using the missing features
    doesn't work on old kernels.  Because it added both attr.cgroup bit and
    PERF_SAMPLE_CGROUP bit, it needs to check whichever comes first (usually
    the actual event, not dummy).
    
    But it only checks the attr.cgroup bit which is set only in the dummy
    event so cannot detect failtures due the sample bits.  Also we don't
    ignore the missing feature and retry, it'd be better checking it with
    the API probing logic.
    
    Committer notes:
    
    Extracted the minimal part to check using the new cgroup API probe
    routine, the part that removes the cgroup member can be left for further
    discussion.
    Signed-off-by: default avatarNamhyung Kim <namhyung@kernel.org>
    Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
    Cc: Andi Kleen <ak@linux.intel.com>
    Cc: Ian Rogers <irogers@google.com>
    Cc: Jiri Olsa <jolsa@redhat.com>
    Cc: Mark Rutland <mark.rutland@arm.com>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Link: http://lore.kernel.org/lkml/20210527182835.1634339-1-namhyung@kernel.orgSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    4f2abe91
perf_api_probe.c 3.79 KB