• Meenakshikumar Somasundaram's avatar
    drm/amd/display: Support for DMUB AUX · 4f8e37db
    Meenakshikumar Somasundaram authored
    [WHY]
    To process AUX transactions with DMUB using inbox1 and outbox1 mail boxes.
    
    [HOW]
    1) Added inbox1 command DMUB_CMD__DP_AUX_ACCESS to issue AUX commands
       to DMUB in dc_process_dmub_aux_transfer_async(). DMUB processes AUX cmd
       with DCN and sends reply back in an outbox1 message triggering an
       outbox1 interrupt to driver.
    2) In existing driver implementation, AUX commands are processed
       synchronously by configuring DCN reg. But in DMUB AUX, driver sends an
       inbox1 message and waits for a conditional variable (CV) which will be
       signaled by outbox1 ISR.
    3) As the driver holds dal and dc locks while waiting for CV, the outbox1
       ISR is registered with noMutexWait set to true, which allows ISR to run
       and signal CV. This sets a constraint on ISR to not modify variables
       such as dc, dmub, etc.
    4) Created dmub_outbox.c with dmub_enable_outbox_notification() to enable
       outbox1 mailbox.
    5) New mailbox address ranges allocated for outbox1 of size DMUB_RB_SIZE.
       Created dmub functions for Outbox1: dmub_dcn20_setup_out_mailbox(),
       dmub_dcn20_get_outbox1_wptr() and dmub_dcn20_set_outbox1_rptr().
    6) Added functions dc_stat_get_dmub_notification() and
       dmub_srv_stat_get_notification() to retrieve Outbox1 message.
    7) Currently, DMUB doesn't opens DDC in AUX mode before issuing AUX
       transaction. A workaround is added in dce_aux_transfer_dmub_raw() to
       open in DDC in AUX mode for every AUX transaction.
    8) Added dc debug option enable_dmub_aux_for_legacy_ddc enable/disable
       DMUB AUX. This debug option is checked dce_aux_transfer_with_retries()
       to select the method to process AUX transactions.
    Tested-by: default avatarDaniel Wheeler <daniel.wheeler@amd.com>
    Signed-off-by: default avatarMeenakshikumar Somasundaram <meenakshikumar.somasundaram@amd.com>
    Reviewed-by: default avatarJun Lei <Jun.Lei@amd.com>
    Acked-by: default avatarRodrigo Siqueira <Rodrigo.Siqueira@amd.com>
    Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
    4f8e37db
dce_aux.c 18.6 KB