• David Gibson's avatar
    ibmveth: Fix off-by-one error in ibmveth_change_mtu() · 4fce1482
    David Gibson authored
    AFAIK the PAPR document which defines the virtual device interface used by
    the ibmveth driver doesn't specify a specific maximum MTU.  So, in the
    ibmveth driver, the maximum allowed MTU is determined by the maximum
    allocated buffer size of 64k (corresponding to one page in the common case)
    minus the per-buffer overhead IBMVETH_BUFF_OH (which has value 22 for 14
    bytes of ethernet header, plus 8 bytes for an opaque handle).
    
    This suggests a maximum allowable MTU of 65514 bytes, but in fact the
    driver only permits a maximum MTU of 65513.  This is because there is a <
    instead of an <= in ibmveth_change_mtu(), which only permits an MTU which
    is strictly smaller than the buffer size, rather than allowing the buffer
    to be completely filled.
    
    This patch fixes the buglet.
    Signed-off-by: default avatarDavid Gibson <david@gibson.dropbear.id.au>
    Acked-by: default avatarThomas Falcon <tlfalcon@linux.vnet.ibm.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    4fce1482
ibmveth.c 44 KB