• Shay Agroskin's avatar
    net: ena: fix DMA mapping function issues in XDP · 504fd6a5
    Shay Agroskin authored
    This patch fixes several bugs found when (DMA/LLQ) mapping a packet for
    transmission. The mapping procedure makes the transmitted packet
    accessible by the device.
    When using LLQ, this requires copying the packet's header to push header
    (which would be passed to LLQ) and creating DMA mapping for the payload
    (if the packet doesn't fit the maximum push length).
    When not using LLQ, we map the whole packet with DMA.
    
    The following bugs are fixed in the code:
        1. Add support for non-LLQ machines:
           The ena_xdp_tx_map_frame() function assumed that LLQ is
           supported, and never mapped the whole packet using DMA. On some
           instances, which don't support LLQ, this causes loss of traffic.
    
        2. Wrong DMA buffer length passed to device:
           When using LLQ, the first 'tx_max_header_size' bytes of the
           packet would be copied to push header. The rest of the packet
           would be copied to a DMA'd buffer.
    
        3. Freeing the XDP buffer twice in case of a mapping error:
           In case a buffer DMA mapping fails, the function uses
           xdp_return_frame_rx_napi() to free the RX buffer and returns from
           the function with an error. XDP frames that fail to xmit get
           freed by the kernel and so there is no need for this call.
    
    Fixes: 548c4940 ("net: ena: Implement XDP_TX action")
    Signed-off-by: default avatarShay Agroskin <shayagr@amazon.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    504fd6a5
ena_netdev.c 123 KB