• Jiri Slaby's avatar
    FS: cifs, remove unneeded NULL tests · 50ae28f0
    Jiri Slaby authored
    Stanse found that pSMBFile in cifs_ioctl and file->f_path.dentry in
    cifs_user_write are dereferenced prior their test to NULL.
    
    The alternative is not to dereference them before the tests. The patch is
    to point out the problem, you have to decide.
    
    While at it we cache the inode in cifs_user_write to a local variable
    and use all over the function.
    Signed-off-by: default avatarJiri Slaby <jslaby@suse.cz>
    Cc: Steve French <sfrench@samba.org>
    Cc: linux-cifs@vger.kernel.org
    Cc: Jeff Layton <jlayton@redhat.com>
    Cc: Christoph Hellwig <hch@infradead.org>
    Signed-off-by: default avatarSteve French <sfrench@us.ibm.com>
    50ae28f0
ioctl.c 2.62 KB