• Yonghong Song's avatar
    bpf: reject program if a __user tagged memory accessed in kernel way · c6f1bfe8
    Yonghong Song authored
    BPF verifier supports direct memory access for BPF_PROG_TYPE_TRACING type
    of bpf programs, e.g., a->b. If "a" is a pointer
    pointing to kernel memory, bpf verifier will allow user to write
    code in C like a->b and the verifier will translate it to a kernel
    load properly. If "a" is a pointer to user memory, it is expected
    that bpf developer should be bpf_probe_read_user() helper to
    get the value a->b. Without utilizing BTF __user tagging information,
    current verifier will assume that a->b is a kernel memory access
    and this may generate incorrect result.
    
    Now BTF contains __user information, it can check whether the
    pointer points to a user memory or not. If it is, the verifier
    can reject the program and force users to use bpf_probe_read_user()
    helper explicitly.
    
    In the future, we can easily extend btf_add_space for other
    address space tagging, for example, rcu/percpu etc.
    Signed-off-by: default avatarYonghong Song <yhs@fb.com>
    Link: https://lore.kernel.org/r/20220127154606.654961-1-yhs@fb.comSigned-off-by: default avatarAlexei Starovoitov <ast@kernel.org>
    c6f1bfe8
bpf_dummy_struct_ops.c 4.76 KB