• Brian Norris's avatar
    mwifiex: pcie: clean up error prints in mwifiex_pcie_reset_notify() · 52033415
    Brian Norris authored
    We shouldn't be printing a kernel pointer as a decimal integer. But we
    really shouldn't be printing this case at all; we should never get here
    with NULL drvdata. We've eliminated this unnecessary conditional in
    several other places, so kill it here too.
    
    Similarly, there's no need to check for '!pdev'; we are guaranteed to
    have a real device here.
    
    And finally, use dev_err() instead of pr_err().
    
    This yields (for failed PCIe resets):
    
    [   68.286586] mwifiex_pcie 0000:01:00.0: mwifiex_pcie_reset_notify: adapter structure is not valid
    
    instead of:
    
    [   82.932658] mwifiex_pcie: mwifiex_pcie_reset_notify: Card or adapter structure is not valid (-270880688088)
    Signed-off-by: default avatarBrian Norris <briannorris@chromium.org>
    Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
    52033415
pcie.c 84.1 KB