• Manfred Schlaegl's avatar
    leds: trigger: ledtrig-backlight: Fix invalid memory access in fb_event notification callback · c945cbcf
    Manfred Schlaegl authored
    fb_notifier_callback is called on any event fired by
    fb_notifier_call_chain. Events may, or may not contain some data
    (fb_event.data). In case of FB_EVENT_BLANK fb_event.data contains a
    pointer to an integer holdingthe blank state. The Problem is, that in
    ledtrig-backlight.c - fb_notifier_callback the pointer to blank state
    is dereferenced BEFORE the event-type is checked.
    
    Obviously this leads to problems with other events than FB_EVENT_BLANK,
    where fb_event.data is undefined or NULL. It seems, that this problem
    existed ever since the driver was added.
    
    Like in drivers/video/backlight/backlight.c line 43 I would suggest to
    return immediately on events other than FB_EVENT_BLANK.
    Signed-off-by: default avatarManfred Schlaegl <manfred.schlaegl@gmx.at>
    Signed-off-by: default avatarBryan Wu <cooloney@gmail.com>
    c945cbcf
ledtrig-backlight.c 3.73 KB