You need to sign in or sign up before continuing.
-
Rafael J. Wysocki authored
Commit b6846826 ("thermal: gov_step_wise: Restore passive polling management") attempted to fix a Step-Wise thermal governor issue introduced by commit 042a3d80 ("thermal: core: Move passive polling management to the core"), which caused the governor to leave cooling devices in high states, by partially reverting that commit. However, this turns out to be insufficient on some systems due to interactions between the governor code restored by commit b6846826 and the passive polling management in the thermal core. For this reason, revert commit b6846826 and make the governor set the target cooling device state to the "lower" one as soon as the zone temperature falls below the threshold of the trip point corresponding to the given thermal instance, which means that thermal mitigation is not necessary any more. Before this change the "lower" cooling device state would be reached in steps through the passive polling mechanism which was questionable for three reasons: (1) cooling device were kept in high states when that was not necessary (and it could adversely impact performance), (2) it only worked for thermal zones with nonzero passive_delay_jiffies value, and (3) passive polling belongs to the core and should not be hijacked by governors for their internal purposes. Fixes: b6846826 ("thermal: gov_step_wise: Restore passive polling management") Closes: https://lore.kernel.org/linux-pm/6759ce9f-281d-4fcd-bb4c-b784a1cc5f6e@oldschoolsolutions.biz Reported-by:
Jens Glathe <jens.glathe@oldschoolsolutions.biz> Tested-by:
Rafael J. Wysocki <rafael.j.wysocki@intel.com> Tested-by:
Steev Klimaszewski <steev@kali.org> Tested-by:
Johan Hovold <johan+linaro@kernel.org>
52903814
