• Ian Rogers's avatar
    perf vendor events intel: Fix modifier in tma_info_system_mem_parallel_reads for skylake · bdc60129
    Ian Rogers authored
    The metric is using the wrong format encoding. This fix is in the
    converter script PR: https://github.com/intel/perfmon/pull/101
    
    Committer testing:
    
    Tested on a Lenovo t480s, before 'perf test 100' was failing with:
    
     # perf test 100
      100: perf all metrics test                                           : FAILED!
    
    With 'perf test -vv 100' we can see:
    
    <SNIP>
      Testing MemoryBW
      Not grouping metric tma_fb_full's events.
      Try disabling the NMI watchdog to comply NO_NMI_WATCHDOG metric constraint:
          echo 0 > /proc/sys/kernel/nmi_watchdog
          perf stat ...
          echo 1 > /proc/sys/kernel/nmi_watchdog
      event syntax error: '...DATA_READ/thresh=1,metric-id=UNC_ARB_TRK_OCCUPANCY.DATA_READ!3thresh!21!3/,UNC_ARB_TRK_OCCUPANCY.DATA_READ/metric-id=UNC_ARB_TRK_OCCUPANCY.DATA_READ/}:W,duration_time'
                                        \___ Bad event or PMU
    
      Unable to find PMU or event on a PMU of 'UNC_ARB_TRK_OCCUPANCY.DATA_READ'
    <SNIP>
    
    With the patch this problem is gone.
    Reported-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    Signed-off-by: default avatarIan Rogers <irogers@google.com>
    Tested-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    Cc: Adrian Hunter <adrian.hunter@intel.com>
    Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
    Cc: Caleb Biggers <caleb.biggers@intel.com>
    Cc: Edward Baker <edward.baker@intel.com>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: Jiri Olsa <jolsa@kernel.org>
    Cc: Kan Liang <kan.liang@linux.intel.com>
    Cc: Mark Rutland <mark.rutland@arm.com>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Cc: Perry Taylor <perry.taylor@intel.com>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Samantha Alt <samantha.alt@intel.com>
    Cc: Weilin Wang <weilin.wang@intel.com>
    Link: https://lore.kernel.org/r/20230830175543.1911892-1-irogers@google.comSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    bdc60129
skl-metrics.json 118 KB