• Colin Ian King's avatar
    drm/vmwgfx: Correctly NULLify dma buffer pointer on failure · da5efffc
    Colin Ian King authored
    cppcheck on lines 917 and 977 show an ineffective assignment
    to the dma buffer pointer:
    
    [drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c:917]:
    [drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c:977]:
      (warning) Assignment of function parameter has no effect
      outside the function. Did you forget dereferencing it?
    
    On a successful DMA buffer lookup, the dma buffer pointer is
    assigned, however, on failure it currently is left in an
    undefined state.
    
    The original intention in the error exit path was to nullify
    the pointer on an error (which the original code failed to
    do properly). This patch fixes this also ensures all failure
    paths nullify the buffer pointer on the error return.
    
    Fortunately the callers to vmw_translate_mob_ptr and
    vmw_translate_guest_ptr are checking on a return status and not
    on the dma buffer pointer, so the original code worked.
    Reviewed-by: default avatarThomas Hellstrom <thellstrom@vmware.com>
    Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
    da5efffc
vmwgfx_execbuf.c 79.4 KB