• Dongdong Deng's avatar
    x86: Avoid calling arch_trigger_all_cpu_backtrace() at the same time · 554ec063
    Dongdong Deng authored
    The spin_lock_debug/rcu_cpu_stall detector uses
    trigger_all_cpu_backtrace() to dump cpu backtrace.
    Therefore it is possible that trigger_all_cpu_backtrace()
    could be called at the same time on different CPUs, which
    triggers and 'unknown reason NMI' warning. The following case
    illustrates the problem:
    
          CPU1                    CPU2                     ...   CPU N
                           trigger_all_cpu_backtrace()
                           set "backtrace_mask" to cpu mask
                                   |
    generate NMI interrupts  generate NMI interrupts       ...
        \                          |                               /
         \                         |                              /
    
    The "backtrace_mask" will be cleaned by the first NMI interrupt
    at nmi_watchdog_tick(), then the following NMI interrupts
    generated by other cpus's arch_trigger_all_cpu_backtrace() will
    be taken as unknown reason NMI interrupts.
    
    This patch uses a test_and_set to avoid the problem, and stop
    the arch_trigger_all_cpu_backtrace() from calling to avoid
    dumping a double cpu backtrace info when there is already a
    trigger_all_cpu_backtrace() in progress.
    Signed-off-by: default avatarDongdong Deng <dongdong.deng@windriver.com>
    Reviewed-by: default avatarBruce Ashfield <bruce.ashfield@windriver.com>
    Cc: fweisbec@gmail.com
    LKML-Reference: <1294198689-15447-2-git-send-email-dzickus@redhat.com>
    Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
    Signed-off-by: default avatarDon Zickus <dzickus@redhat.com>
    554ec063
hw_nmi.c 2.41 KB