• Frederic Weisbecker's avatar
    hw-breakpoints: Fix task-bound breakpoint slot allocation · 56053170
    Frederic Weisbecker authored
    Whatever the context nature of a breakpoint, we always perform the
    following constraint checks before allocating it a slot:
    
    - Check the number of pinned breakpoint bound the concerned cpus
    - Check the max number of task-bound breakpoints that are belonging
      to a task.
    - Add both and see if we have a reamining slot for the new breakpoint
    
    This is the right thing to do when we are about to register a cpu-only
    bound breakpoint. But not if we are dealing with a task bound
    breakpoint. What we want in this case is:
    
    - Check the number of pinned breakpoint bound the concerned cpus
    - Check the number of breakpoints that already belong to the task
      in which the breakpoint to register is bound to.
    - Add both
    
    This fixes a regression that makes the "firefox -g" command fail to
    register breakpoints once we deal with a secondary thread.
    Reported-by: default avatarWalt <w41ter@gmail.com>
    Signed-off-by: default avatarFrederic Weisbecker <fweisbec@gmail.com>
    Cc: Prasad <prasad@linux.vnet.ibm.com>
    56053170
hw_breakpoint.c 10.9 KB