• Ingo Molnar's avatar
    perf/x86/intel: Revert incomplete and undocumented Broadwell client support · 1776b106
    Ingo Molnar authored
    These patches:
    
      86a349a2 ("perf/x86/intel: Add Broadwell core support")
      c46e665f ("perf/x86: Add INST_RETIRED.ALL workarounds")
      fdda3c4a ("perf/x86/intel: Use Broadwell cache event list for Haswell")
    
    introduced magic constants and unexplained changes:
    
      https://lkml.org/lkml/2014/10/28/1128
      https://lkml.org/lkml/2014/10/27/325
      https://lkml.org/lkml/2014/8/27/546
      https://lkml.org/lkml/2014/10/28/546
    
    Peter Zijlstra has attempted to help out, to clean up the mess:
    
      https://lkml.org/lkml/2014/10/28/543
    
    But has not received helpful and constructive replies which makes
    me doubt wether it can all be finished in time until v3.18 is
    released.
    
    Despite various review feedback the author (Andi Kleen) has answered
    only few of the review questions and has generally been uncooperative,
    only giving replies when prompted repeatedly, and only giving minimal
    answers instead of constructively explaining and helping along the effort.
    
    That kind of behavior is not acceptable.
    
    There's also a boot crash on Intel E5-1630 v3 CPUs reported for another
    commit from Andi Kleen:
    
      e735b9db ("perf/x86/intel/uncore: Add Haswell-EP uncore support")
    
      https://lkml.org/lkml/2014/10/22/730
    
    Which is not yet resolved. The uncore driver is independent in theory,
    but the crash makes me worry about how well all these patches were
    tested and makes me uneasy about the level of interminging that the
    Broadwell and Haswell code has received by the commits above.
    
    As a first step to resolve the mess revert the Broadwell client commits
    back to the v3.17 version, before we run out of time and problematic
    code hits a stable upstream kernel.
    
    ( If the Haswell-EP crash is not resolved via a simple fix then we'll have
      to revert the Haswell-EP uncore driver as well. )
    
    The Broadwell client series has to be submitted in a clean fashion, with
    single, well documented changes per patch. If they are submitted in time
    and are accepted during review then they can possibly go into v3.19 but
    will need additional scrutiny due to the rocky history of this patch set.
    
    Cc: Andi Kleen <ak@linux.intel.com>
    Cc: Peter Zijlstra (Intel) <peterz@infradead.org>
    Cc: eranian@google.com
    Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Link: http://lkml.kernel.org/r/1409683455-29168-3-git-send-email-andi@firstfloor.orgSigned-off-by: default avatarIngo Molnar <mingo@kernel.org>
    1776b106
perf_event_intel.c 73.9 KB