• Douglas Anderson's avatar
    Revert "brcmfmac: disable command decode in sdio_aos" · 56f92e34
    Douglas Anderson authored
    commit abdd5dcc upstream.
    
    This reverts commit 29f65891.
    
    After that patch landed I find that my kernel log on
    rk3288-veyron-minnie and rk3288-veyron-speedy is filled with:
    brcmfmac: brcmf_sdio_bus_sleep: error while changing bus sleep state -110
    
    This seems to happen every time the Broadcom WiFi transitions out of
    sleep mode.  Reverting the commit fixes the problem for me, so that's
    what this patch does.
    
    Note that, in general, the justification in the original commit seemed
    a little weak.  It looked like someone was testing on a SD card
    controller that would sometimes die if there were CRC errors on the
    bus.  This used to happen back in early days of dw_mmc (the controller
    on my boards), but we fixed it.  Disabling a feature on all boards
    just because one SD card controller is broken seems bad.
    
    Fixes: 29f65891 ("brcmfmac: disable command decode in sdio_aos")
    Cc: Wright Feng <wright.feng@cypress.com>
    Cc: Double Lo <double.lo@cypress.com>
    Cc: Madhan Mohan R <madhanmohan.r@cypress.com>
    Cc: Chi-Hsien Lin <chi-hsien.lin@cypress.com>
    Signed-off-by: default avatarDouglas Anderson <dianders@chromium.org>
    Cc: stable@vger.kernel.org
    Acked-by: default avatarKalle Valo <kvalo@codeaurora.org>
    Signed-off-by: default avatarUlf Hansson <ulf.hansson@linaro.org>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    56f92e34
sdio.c 121 KB