• Yann Sionneau's avatar
    i2c: designware: fix __i2c_dw_disable() in case master is holding SCL low · 2409205a
    Yann Sionneau authored
    The DesignWare IP can be synthesized with the IC_EMPTYFIFO_HOLD_MASTER_EN
    parameter.
    In this case, when the TX FIFO gets empty and the last command didn't have
    the STOP bit (IC_DATA_CMD[9]), the controller will hold SCL low until
    a new command is pushed into the TX FIFO or the transfer is aborted.
    
    When the controller is holding SCL low, it cannot be disabled.
    The transfer must first be aborted.
    Also, the bus recovery won't work because SCL is held low by the master.
    
    Check if the master is holding SCL low in __i2c_dw_disable() before trying
    to disable the controller. If SCL is held low, an abort is initiated.
    When the abort is done, then proceed with disabling the controller.
    
    This whole situation can happen for instance during SMBus read data block
    if the slave just responds with "byte count == 0".
    This puts the driver in an unrecoverable state, because the controller is
    holding SCL low and the current __i2c_dw_disable() procedure is not
    working. In this situation only a SoC reset can fix the i2c bus.
    Co-developed-by: default avatarJonathan Borne <jborne@kalray.eu>
    Signed-off-by: default avatarJonathan Borne <jborne@kalray.eu>
    Signed-off-by: default avatarYann Sionneau <ysionneau@kalray.eu>
    Acked-by: default avatarJarkko Nikula <jarkko.nikula@linux.intel.com>
    Signed-off-by: default avatarWolfram Sang <wsa@kernel.org>
    2409205a
i2c-designware-common.c 16.2 KB