• Petr Machata's avatar
    net: ipv4: Allow changing IPv4 address protocol · 5c4a9aa8
    Petr Machata authored
    When IP address protocol field was added in commit 47f0bd50 ("net: Add
    new protocol attribute to IP addresses"), the semantics included the
    ability to change the protocol for IPv6 addresses, but not for IPv4
    addresses. It seems this was not deliberate, but rather by accident.
    
    A userspace that wants to change the protocol of an address might drop and
    recreate the address, but that disrupts routing and is just impractical.
    
    So in this patch, when an IPv4 address is replaced (through RTM_NEWADDR
    request with NLM_F_REPLACE flag), update the proto at the address to the
    one given in the request, or zero if none is given. This matches the
    behavior of IPv6. Previously, any new value given was simply ignored.
    Signed-off-by: default avatarPetr Machata <petrm@nvidia.com>
    Reviewed-by: default avatarIdo Schimmel <idosch@nvidia.com>
    Reviewed-by: default avatarDavid Ahern <dsahern@kernel.org>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    5c4a9aa8
devinet.c 69.1 KB