• Arnaldo Carvalho de Melo's avatar
    perf unwind: Do not put libunwind-{x86,aarch64} in FEATURE_TESTS_BASIC · 5c4d7c82
    Arnaldo Carvalho de Melo authored
    As it is not normally available on x86_64 not being tested on test-all.c
    but being in FEATURE_TESTS_BASIC ends up implying that those features
    are present, which leads to trying to link with those libraries and a
    build failure now that test-all.c is finally again building
    successfully:
    
      /usr/bin/ld: cannot find -lunwind-x86
      /usr/bin/ld: cannot find -lunwind-aarch64
      collect2: error: ld returned 1 exit status
      make[3]: *** [Makefile:199: /tmp/build/perf/plugin_jbd2.so] Error 1
      make[3]: *** Waiting for unfinished jobs....
      /usr/bin/ld: cannot find -lunwind-x86
      /usr/bin/ld: cannot find -lunwind-aarch64
    
    So remove those features from there and explicitely test them.
    
    And then move this patch to just before the last one that allows this to
    be exposed, so that we keep the tree bisectable.
    
    With all this in place we get, at this point:
    
      $ ldd /tmp/build/perf/feature/test-libunwind.bin
    	linux-vdso.so.1 (0x00007fffa09c6000)
    	libunwind-x86_64.so.8 => /lib64/libunwind-x86_64.so.8 (0x00007fbcf4451000)
    	libunwind.so.8 => /lib64/libunwind.so.8 (0x00007fbcf4435000)
    	liblzma.so.5 => /lib64/liblzma.so.5 (0x00007fbcf440c000)
    	libelf.so.1 => /lib64/libelf.so.1 (0x00007fbcf43f2000)
    	libc.so.6 => /lib64/libc.so.6 (0x00007fbcf422c000)
    	libgcc_s.so.1 => /lib64/libgcc_s.so.1 (0x00007fbcf4211000)
    	/lib64/ld-linux-x86-64.so.2 (0x00007fbcf4491000)
    	libpthread.so.0 => /lib64/libpthread.so.0 (0x00007fbcf41ed000)
    	libz.so.1 => /lib64/libz.so.1 (0x00007fbcf41d3000)
      $ cat /tmp/build/perf/feature/test-libunwind-x86.make.output
      test-libunwind-x86.c:2:10: fatal error: libunwind-x86.h: No such file or directory
       #include <libunwind-x86.h>
                ^~~~~~~~~~~~~~~~~
      compilation terminated.
      $ cat /tmp/build/perf/feature/test-libunwind-aarch64.make.output
      test-libunwind-aarch64.c:2:10: fatal error: libunwind-aarch64.h: No such file or directory
      #include <libunwind-aarch64.h>
               ^~~~~~~~~~~~~~~~~~~~~
      compilation terminated.
      $
      $ ldd ~/bin/perf | grep unwind
    	libunwind-x86_64.so.8 => /lib64/libunwind-x86_64.so.8 (0x00007f5ceb24b000)
    	libunwind.so.8 => /lib64/libunwind.so.8 (0x00007f5ceb22f000)
      $
    
    Cc: Adrian Hunter <adrian.hunter@intel.com>
    Cc: He Kuang <hekuang@huawei.com>
    Cc: Jean Pihet <jean.pihet@linaro.org>
    Cc: Jiri Olsa <jolsa@kernel.org>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Cc: Wang Nan <wangnan0@huawei.com>
    Cc: Will Deacon <will.deacon@arm.com>
    Link: https://lkml.kernel.org/n/tip-vs6kwqsvwk7oxhs6z9mq87pp@git.kernel.orgSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    5c4d7c82
Makefile.feature 7.85 KB