• Miklos Szeredi's avatar
    fuse: make sure reclaim doesn't write the inode · 5c791fe1
    Miklos Szeredi authored
    In writeback cache mode mtime/ctime updates are cached, and flushed to the
    server using the ->write_inode() callback.
    
    Closing the file will result in a dirty inode being immediately written,
    but in other cases the inode can remain dirty after all references are
    dropped.  This result in the inode being written back from reclaim, which
    can deadlock on a regular allocation while the request is being served.
    
    The usual mechanisms (GFP_NOFS/PF_MEMALLOC*) don't work for FUSE, because
    serving a request involves unrelated userspace process(es).
    
    Instead do the same as for dirty pages: make sure the inode is written
    before the last reference is gone.
    
     - fallocate(2)/copy_file_range(2): these call file_update_time() or
       file_modified(), so flush the inode before returning from the call
    
     - unlink(2), link(2) and rename(2): these call fuse_update_ctime(), so
       flush the ctime directly from this helper
    Reported-by: default avatarchenguanyou <chenguanyou@xiaomi.com>
    Signed-off-by: default avatarMiklos Szeredi <mszeredi@redhat.com>
    5c791fe1
inode.c 45.3 KB