• Larry Finger's avatar
    b43: Fix firmware loading when driver is built into the kernel · 5e20a4b5
    Larry Finger authored
    Recent versions of udev cause synchronous firmware loading from the
    probe routine to fail because the request to user space would time
    out. The original fix for b43 (commit 6b6fa586) moved the firmware
    load from the probe routine to a work queue, but it still used synchronous
    firmware loading. This method is OK when b43 is built as a module;
    however, it fails when the driver is compiled into the kernel.
    
    This version changes the code to load the initial firmware file
    using request_firmware_nowait(). A completion event is used to
    hold the work queue until that file is available. This driver
    reads several firmware files - the remainder can be read synchronously.
    On some test systems, the async read fails; however, a following synch
    read works, thus the async failure falls through to the sync try.
    
    Reported-and-Tested by: Felix Janda <felix.janda@posteo.de>
    Signed-off-by: default avatarLarry Finger <Larry.Finger@lwfinger.net>
    Cc: Stable <stable@vger.kernel.org>  (V3.4+)
    Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
    5e20a4b5
b43.h 40.6 KB