• Johan Hovold's avatar
    USB: serial: spcp8x5: fix modem-status handling · 5ed8d410
    Johan Hovold authored
    Make sure to detect short control transfers and return zero on success
    when retrieving the modem status.
    
    This fixes the TIOCMGET implementation which since e1ed212d ("USB:
    spcp8x5: add proper modem-status support") has returned TIOCM_LE on
    successful retrieval, and avoids leaking bits from the stack on short
    transfers.
    
    This also fixes the carrier-detect implementation which since the above
    mentioned commit unconditionally has returned true.
    
    Fixes: e1ed212d ("USB: spcp8x5: add proper modem-status support")
    Cc: stable <stable@vger.kernel.org>
    Reviewed-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
    5ed8d410
spcp8x5.c 13.1 KB