• Bjorn Helgaas's avatar
    bnx2: Drop redundant pci_enable_pcie_error_reporting() · 5f00358b
    Bjorn Helgaas authored
    pci_enable_pcie_error_reporting() enables the device to send ERR_*
    Messages.  Since f26e58bf ("PCI/AER: Enable error reporting when AER is
    native"), the PCI core does this for all devices during enumeration, so the
    driver doesn't need to do it itself.
    
    Remove the redundant pci_enable_pcie_error_reporting() call from the
    driver.  Also remove the corresponding pci_disable_pcie_error_reporting()
    from the driver .remove() path.
    
    Note that this only controls ERR_* Messages from the device.  An ERR_*
    Message may cause the Root Port to generate an interrupt, depending on the
    AER Root Error Command register managed by the AER service driver.
    
    cd709aa9 ("bnx2: Add PCI Advanced Error Reporting support.") added
    pci_enable_pcie_error_reporting() for all devices, and c239f279 ("bnx2:
    Enable AER on PCIE devices only") restricted it to BNX2_CHIP_5709 devices
    to avoid an error message when it failed on non-PCIe devices.  The PCI core
    only enables PCIe error reporting on PCIe devices, which I assume means
    BNX2_CHIP_5709.
    Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
    Cc: Rasesh Mody <rmody@marvell.com>
    Cc: GR-Linux-NIC-Dev@marvell.com
    Reviewed-by: default avatarMichael Chan <michael.chan@broadcom.com>
    Acked-by: default avatarJesse Brandeburg <jesse.brandeburg@intel.com>
    Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
    5f00358b
bnx2.c 215 KB