• Hans de Goede's avatar
    platform/x86/intel/vsec: Fix wrong type for local status variables · 3d46d784
    Hans de Goede authored
    The local status variables in intel_vsec_pci_error_detected()
    and intel_vsec_pci_slot_reset() should have pci_ers_result_t as type
    (and not pci_channel_state_t).
    
    Also fix a whitespace error as well as intel_vsec_pci_err_handlers not
    being marked static.
    
    This fixes the following sparse errors:
    
    drivers/platform/x86/intel/vsec.c:429:38: sparse: sparse: incorrect type in initializer (different base types) @@     expected restricted pci_channel_state_t [usertype] status @@     got restricted pci_ers_result_t @@
    drivers/platform/x86/intel/vsec.c:429:38: sparse:     expected restricted pci_channel_state_t [usertype] status
    drivers/platform/x86/intel/vsec.c:429:38: sparse:     got restricted pci_ers_result_t
    drivers/platform/x86/intel/vsec.c:434:24: sparse: sparse: incorrect type in assignment (different base types) @@     expected restricted pci_channel_state_t [usertype] status @@     got restricted pci_ers_result_t @@
    drivers/platform/x86/intel/vsec.c:434:24: sparse:     expected restricted pci_channel_state_t [usertype] status
    drivers/platform/x86/intel/vsec.c:434:24: sparse:     got restricted pci_ers_result_t
    drivers/platform/x86/intel/vsec.c:438:16: sparse: sparse: incorrect type in return expression (different base types) @@     expected restricted pci_ers_result_t @@     got restricted pci_channel_state_t [usertype] status @@
    drivers/platform/x86/intel/vsec.c:438:16: sparse:     expected restricted pci_ers_result_t
    drivers/platform/x86/intel/vsec.c:438:16: sparse:     got restricted pci_channel_state_t [usertype] status
    drivers/platform/x86/intel/vsec.c:444:38: sparse: sparse: incorrect type in initializer (different base types) @@     expected restricted pci_channel_state_t [usertype] status @@     got restricted pci_ers_result_t @@
    drivers/platform/x86/intel/vsec.c:444:38: sparse:     expected restricted pci_channel_state_t [usertype] status
    drivers/platform/x86/intel/vsec.c:444:38: sparse:     got restricted pci_ers_result_t
    drivers/platform/x86/intel/vsec.c:457:16: sparse: sparse: incorrect type in assignment (different base types) @@     expected restricted pci_channel_state_t [usertype] status @@     got restricted pci_ers_result_t @@
    drivers/platform/x86/intel/vsec.c:457:16: sparse:     expected restricted pci_channel_state_t [usertype] status
    drivers/platform/x86/intel/vsec.c:457:16: sparse:     got restricted pci_ers_result_t
    drivers/platform/x86/intel/vsec.c:472:16: sparse: sparse: incorrect type in return expression (different base types) @@     expected restricted pci_ers_result_t @@     got restricted pci_channel_state_t [usertype] status @@
    drivers/platform/x86/intel/vsec.c:472:16: sparse:     expected restricted pci_ers_result_t
    drivers/platform/x86/intel/vsec.c:472:16: sparse:     got restricted pci_channel_state_t [usertype] status
    drivers/platform/x86/intel/vsec.c:480:33: sparse: sparse: symbol 'intel_vsec_pci_err_handlers' was not declared. Should it be static?
    Reported-by: default avatarkernel test robot <lkp@intel.com>
    Cc: Srinivas Pandruvada <srinivas.pandruvada@intel.com>
    Cc: David E Box <david.e.box@intel.com>
    Cc: Gayatri Kammela <gayatri.kammela@linux.intel.com>
    Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
    Link: https://lore.kernel.org/r/20220801145536.172410-1-hdegoede@redhat.com
    3d46d784
vsec.c 12.2 KB