• Edwin Peer's avatar
    bnxt_en: init RSS table for Minimal-Static VF reservation · 5fa65524
    Edwin Peer authored
    There are no VF rings available during probe when the device is configured
    using the Minimal-Static reservation strategy. In this case, the RSS
    indirection table can only be initialized later, during bnxt_open_nic().
    However, this was not happening because the rings will already have been
    reserved via bnxt_init_dflt_ring_mode(), causing bnxt_need_reserve_rings()
    to return false in bnxt_reserve_rings() and bypass the RSS table init.
    
    Solve this by pushing the call to bnxt_set_dflt_rss_indir_tbl() into
    __bnxt_reserve_rings(), which is common to both paths and is called
    whenever ring configuration is changed. After doing this, the RSS table
    init that must be called from bnxt_init_one() happens implicitly via
    bnxt_set_default_rings(), necessitating doing the allocation earlier in
    order to avoid a null pointer dereference.
    
    Fixes: bd3191b5 ("bnxt_en: Implement ethtool -X to set indirection table.")
    Signed-off-by: default avatarEdwin Peer <edwin.peer@broadcom.com>
    Signed-off-by: default avatarMichael Chan <michael.chan@broadcom.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    5fa65524
bnxt.c 331 KB