• Herbert Xu's avatar
    net: Ensure partial checksum offset is inside the skb head · 5ff8dda3
    Herbert Xu authored
    On Thu, Jun 04, 2009 at 09:06:00PM +1000, Herbert Xu wrote:
    >
    > tun: Optimise handling of bogus gso->hdr_len
    >
    > As all current versions of virtio_net generate a value for the
    > header length that's too small, we should optimise this so that
    > we don't copy it twice.  This can be done by ensuring that it is
    > at least as large as the place where we'll write the checksum.
    >
    > Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
    
    With this applied we can strengthen the partial checksum check:
    
    In skb_partial_csum_set we check to see if the checksum offset
    is within the packet.  However, we really should check that it
    is within the skb head as that's the only bit we can modify
    without copying.
    Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
    Acked-by: default avatarRusty Russell <rusty@rustcorp.com.au>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    5ff8dda3
skbuff.c 74.5 KB