• Sarah Sharp's avatar
    usb; xhci: Fix TRB offset calculations. · 6071d836
    Sarah Sharp authored
    Greg KH introduced a bug into xhci_trb_virt_to_dma() when he changed the
    type of offset to dma_addr_t from unsigned int and dropped the casts to
    unsigned int around the virtual address pointer subtraction.
    
    trb and seg->trbs are both valid pointers to virtual addresses, so the
    compiler will mod the subtraction by the size of union trb (16 bytes).
    segment_offset is an unsigned long, which is guaranteed to be at least as
    big as a void *.
    
    Drop the void * casts in the first if statement because trb and seg->trbs
    are both pointers of the same type (pointers to union trb).
    Signed-off-by: default avatarSarah Sharp <sarah.a.sharp@linux.intel.com>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
    6071d836
xhci-ring.c 51.9 KB