• Daniel Vetter's avatar
    drm/i915: extract gmbus_wait_hw_status · 61168c53
    Daniel Vetter authored
    The gmbus interrupt generation is rather fiddly: We can only ever
    enable one interrupt source (but we always want to check for NAK
    in addition to the real bit). And the bits in the gmbus status
    register don't map at all to the bis in the irq register.
    
    To prepare for this mess, start by extracting the hw status wait
    loop into it's own function, consolidate the NAK error handling a
    bit. To keep things flexible, pass in the status bit we care about
    (in addition to any NAK signalling).
    
    v2: I've failed to notice that the sense of GMBUS_ACTIVE is inverted,
    Chris Wilson gladly pointed that out for me. To keep things simple,
    ignore that case for  now (we only need to idle the gmbus controller
    at the end of an entire i2c transaction, not after every message).
    Reviewed-by: default avatarImre Deak <imre.deak@intel.com>
    Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
    61168c53
intel_i2c.c 14.2 KB