• David Ahern's avatar
    net: mpls: Fix nexthop alive tracking on down events · 61733c91
    David Ahern authored
    Alive tracking of nexthops can account for a link twice if the carrier
    goes down followed by an admin down of the same link rendering multipath
    routes useless. This is similar to 79099aab for UNREGISTER events and
    DOWN events.
    
    Fix by tracking number of alive nexthops in mpls_ifdown similar to the
    logic in mpls_ifup. Checking the flags per nexthop once after all events
    have been processed is simpler than trying to maintian a running count
    through all event combinations.
    
    Also, WRITE_ONCE is used instead of ACCESS_ONCE to set rt_nhn_alive
    per a comment from checkpatch:
        WARNING: Prefer WRITE_ONCE(<FOO>, <BAR>) over ACCESS_ONCE(<FOO>) = <BAR>
    
    Fixes: c89359a4 ("mpls: support for dead routes")
    Signed-off-by: default avatarDavid Ahern <dsa@cumulusnetworks.com>
    Acked-by: default avatarRobert Shearman <rshearma@brocade.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    61733c91
af_mpls.c 47.1 KB