• Shaohua Li's avatar
    x86, mm: Avoid unnecessary TLB flush · 61c77326
    Shaohua Li authored
    In x86, access and dirty bits are set automatically by CPU when CPU accesses
    memory. When we go into the code path of below flush_tlb_fix_spurious_fault(),
    we already set dirty bit for pte and don't need flush tlb. This might mean
    tlb entry in some CPUs hasn't dirty bit set, but this doesn't matter. When
    the CPUs do page write, they will automatically check the bit and no software
    involved.
    
    On the other hand, flush tlb in below position is harmful. Test creates CPU
    number of threads, each thread writes to a same but random address in same vma
    range and we measure the total time. Under a 4 socket system, original time is
    1.96s, while with the patch, the time is 0.8s. Under a 2 socket system, there is
    20% time cut too. perf shows a lot of time are taking to send ipi/handle ipi for
    tlb flush.
    Signed-off-by: default avatarShaohua Li <shaohua.li@intel.com>
    LKML-Reference: <20100816011655.GA362@sli10-desk.sh.intel.com>
    Acked-by: default avatarSuresh Siddha <suresh.b.siddha@intel.com>
    Cc: Andrea Archangeli <aarcange@redhat.com>
    Signed-off-by: default avatarH. Peter Anvin <hpa@zytor.com>
    61c77326
pgtable.h 10.5 KB