• Vladimir Oltean's avatar
    spi: spi-fsl-dspi: Optimize dspi_setup_accel for lowest interrupt count · 6365504d
    Vladimir Oltean authored
    Currently, a SPI transfer that is not multiple of the highest supported
    word width (e.g. 4 bytes) will be transmitted as follows (assume a
    30-byte buffer transmitted through a 32-bit wide FIFO that is 32 bytes
    deep):
    
     - First 28 bytes are sent as 7 words of 32 bits each
     - Last 2 bytes are sent as 1 word of 16 bits size
    
    But if the dspi_setup_accel function had decided to use a lower
    oper_bits_per_word value (16 instead of 32), there would have been
    enough space in the TX FIFO to fit the entire buffer in one go (15 words
    of 16 bits each).
    
    What we're actually trying to avoid is mixing word sizes within the same
    run with the TX FIFO, since there is an erratum surrounding this, and
    invalid data might get transmitted.
    
    So this patch adds special cases for when the remaining length of the
    buffer can be sent in one go as 8-bit or 16-bit words, otherwise it
    falls back to the standard logic of sending as many bytes as possible at
    the highest oper_bits_per_word value possible.
    
    The benefit is that there will be one less CMDFQ/EOQ interrupt to
    service when the entire buffer is transmitted during a single go, and
    that will improve the overall latency of the transfer.
    Signed-off-by: default avatarVladimir Oltean <vladimir.oltean@nxp.com>
    Link: https://lore.kernel.org/r/20200304220044.11193-11-olteanv@gmail.comSigned-off-by: default avatarMark Brown <broonie@kernel.org>
    6365504d
spi-fsl-dspi.c 35.7 KB