• John W. Linville's avatar
    Revert "iwmc3200wifi: fix array out-of-boundary access" · 79b6a511
    John W. Linville authored
    This reverts commit 6c853da3.
    
    From Message-ID: <1262663293.551.117.camel@debian>
    On Sat, 2010-01-02 at 22:09 +0800, Dan Carpenter wrote:
    > It don't think 6c853da3 is right.  That's the patch
    > titled "iwmc3200wifi: fix array out-of-boundary access"
    >
    >       Allocate priv->rx_packets[IWM_RX_ID_HASH + 1] because the max array
    >       index is IWM_RX_ID_HASH according to IWM_RX_ID_GET_HASH().
    >
    > In 2.6.33-rc2 IWM_RX_ID_GET_HASH() doesn't go as high as IWM_RX_ID_HASH
    > and I don't see any array out-of-bounds.
    >
    > #define IWM_RX_ID_GET_HASH(id) ((id) % IWM_RX_ID_HASH)
    
    Ah, you are right. I took '%' for '&'. John, would you revert it? Sorry
    for the false alarm.
    
    Thanks,
    -yi
    Reported-by: default avatarDan Carpenter <error27@gmail.com>
    Reviewed-by: default avatarZhu Yi <yi.zhu@intel.com>
    Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
    79b6a511
iwm.h 9.31 KB