• Guenter Roeck's avatar
    alarmtimer: Use maximum alarm time for suspend · 8ceea12d
    Guenter Roeck authored
    Some userspace applications use timerfd_create() to request wakeups after
    a long period of time. For example, a backup application may request a
    wakeup once per week. This is perfectly fine as long as the system does
    not try to suspend. However, if the system tries to suspend and the
    system's RTC does not support the required alarm timeout, the suspend
    operation will fail with an error such as
    
    rtc_cmos 00:01: Alarms can be up to one day in the future
    PM: dpm_run_callback(): platform_pm_suspend+0x0/0x4a returns -22
    alarmtimer alarmtimer.4.auto: platform_pm_suspend+0x0/0x4a returned -22 after 117 usecs
    PM: Device alarmtimer.4.auto failed to suspend: error -22
    
    This results in a refusal to suspend the system, causing substantial
    battery drain on affected systems.
    
    To fix the problem, use the maximum alarm time offset as reported by RTC
    drivers to set the maximum alarm time. While this may result in early
    wakeups from suspend, it is still much better than not suspending at all.
    
    Standardize system behavior if the requested alarm timeout is larger than
    the alarm timeout supported by the rtc chip. Currently, in this situation,
    the RTC driver will do one of the following:
    
      - It may return an error.
      - It may limit the alarm timeout to the maximum supported by the rtc chip.
      - It may mask the timeout by the maximum alarm timeout supported by the RTC
        chip (i.e. a requested timeout of 1 day + 1 minute may result in a 1
        minute timeout).
    
    With this in place, if the RTC driver reports the maximum alarm timeout
    supported by the RTC chip, the system will always limit the alarm timeout
    to the maximum supported by the RTC chip.
    Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
    Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
    Acked-by: default avatarJohn Stultz <jstultz@google.com>
    Link: https://lore.kernel.org/r/20230915152238.1144706-3-linux@roeck-us.net
    8ceea12d
alarmtimer.c 24.8 KB